Check for origin and issue warning if origin is incorrect.#62708
Check for origin and issue warning if origin is incorrect.#62708kt-12 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Earlier, before https://core.trac.wordpress.org/ticket/61112, just after the filter, we used to recreate the
WP_Theme_JSON_Data_Gutenbergobject passing the correct origin. Removing that introduced a risk for someone using the filter to accidentally create a new object with a wrong origin.What?
The PR introduces an origin check after the filter.
Why?
There is a high chance that someone using the filter can set a wrong origin. Earlier this wasn't a risk as object was recreated with right origin.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast