Remove and prevent DOM access in block attributes matchers#624
Merged
Conversation
aduth
commented
May 3, 2017
blocks/library/quote/index.js
Outdated
Member
Author
There was a problem hiding this comment.
Ideally we'd not need to coerce style to a number, but instead incorporate into attributes (#609) or serialize comment attributes as typed-ish JSON (#482 (comment)).
Member
|
I like this. |
Merged
7e7c901 to
3e14439
Compare
Member
Author
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #608
This pull request seeks to remove existing attributes matchers which operate on the DOM; currently image and quote blocks pulling attribute values from element class names. Instead, these attributes are to be encoded into the block comment. Further, it seeks to prevent future attributes created in this pattern by applying an internal flag to acceptable attribute matcher creators (
attr,children, etc).Copying an included code comment which elaborates:
Testing instructions:
Ensure that tests pass:
Verify that image alignment and quote styles are still respected, including after changing the values and switching back and forth between Visual and HTML modes.