Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
johnhooks
commented
May 11, 2024
| * The store registry object. | ||
| */ | ||
| registry: DataRegistry; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Example of usage:
import type { ThunkArgs } from "@wordpress/data";
import type { Action, Store, Item } from "./types";
export const receiveItem =
(item: Item) =>
async ({ dispatch, select, registry }: ThunkArgs<Action, Store>) => {
// In this function `dispatch` and `select` are fully typed to the store and action types,
// `registry` is fully typed, if given a fully typed store descriptor.
};fda218d to
68e510c
Compare
68e510c to
7408731
Compare
This commit improves the types in the data package. - Adds new types `ThunkArgs` and `Thunk`. These types are intended to be used by consumers of the data package to define their own thunks. - Adds meta action creators to the `ActionCreatorsOf` type. - Adds the `dispatch` and `select` functions to the `DataRegistry` type. - Adds the `invalidate` action creators to the `ActionCreatorsOf` type. This allows consumers of the data package to have more complete type safety. Also, provides access to the invalidate resolution action creators, which are useful for complex data store manipulation. Adding new types as described above. Building the package types.
7408731 to
b24c90c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This commit improves the types in the data package.
ThunkArgsandThunk. These types are intended to be used by consumers of the data package to define their own thunks.dispatchandselectfunctions to theDataRegistrytype.invalidateaction creators to theActionCreatorsOftype.Why?
This allows consumers of the data package to have more complete type safety. Also, provides access to the invalidate resolution action creators, which are useful for complex data store manipulation.
How?
Adding new types as described above.
Testing Instructions
Building the package types.