Closed
Conversation
|
Size Change: +1.57 kB (+0.09%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
scruffian
reviewed
May 10, 2024
Contributor
scruffian
left a comment
There was a problem hiding this comment.
When I insert a pattern, zoom out is disengaged.
Contributor
|
Maybe we should try double click to disengage zoom out? |
Contributor
|
Found this PR to be a bit jumpy at times in ways that I can't quite understand. While I love that it allows me to operate at a pattern level context to swap between options, I found it jumped around when swapping patterns in a way that left me more confused: jumpy.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
To do: try maintaining grey padding when inserter is opened?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast