Site Editor: Redirect /wp_template_part/all to /patterns#61446
Merged
Conversation
t-hamano
commented
May 7, 2024
| [ '/wp_template', '/wp_template_part/all', '/pages' ].includes( | ||
| path | ||
| ) || | ||
| [ '/wp_template', '/pages' ].includes( path ) || |
Contributor
Author
There was a problem hiding this comment.
The concern about deleting /wp_template_part/all from this array is discussed in this comment, but it should be possible to delete it with this PR.
|
Size Change: +130 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
/wp_template_part/all to /patterns`/wp_template_part/all to /patterns
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
I've tested this with:
Though this last screen is a bit weird when it doesn't have patterns. This is unrelated to this PR, though. |
oandregal
approved these changes
May 10, 2024
oandregal
left a comment
Member
There was a problem hiding this comment.
This works fine for me. Though I welcome a second opinion from someone that has more experience working with the router.
youknowriad
reviewed
May 10, 2024
Contributor
|
Also, this is likely to grow over time (other redirects), so I wonder if we should expose a generic "Redirect" component or something from the router package and use it in the router.js file of the site editor. |
jsnajdr
requested changes
May 10, 2024
Contributor
Author
|
Thanks for the review!
Moved redirect code. |
t-hamano
commented
May 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #61080
See this comment: #61080 (comment)
What?
This PR ensures that when
/wp_template_part/allpath is accessed, it will redirect to/patterns.Why?
The All Template Parts page no longer exist, as template parts have already been integrated into the Patterns page. However, for backward compatibility, the Patterns page was displayed when this path was accessed. We should be able to completely remove references to
/wp_template_part/allby redirecting to the/patternspath.How?
Added redirect to
RouterProvider. It works fine as far as I've tested it, but I'd appreciate some advice if this is the ideal approach.Testing Instructions
http://localhost:8888/wp-admin/site-editor.php?path=/wp_template_part/allin the URL of your browser.http://localhost:8888/wp-admin/site-editor.php?path=/patterns.