fix use local version of theme.json schema in bundled files#61312
Merged
fabiankaegy merged 2 commits intotrunkfrom May 2, 2024
Merged
fix use local version of theme.json schema in bundled files#61312fabiankaegy merged 2 commits intotrunkfrom
fabiankaegy merged 2 commits intotrunkfrom
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
May 2, 2024
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Makes sense. Thank you, @fabiankaegy!
|
Flaky tests detected in 6062620. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8921114390
|
|
Size Change: -82 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Use the bundled
theme.jsonSCHEMA to validate all the bundledtheme.jsonfiles in the Gutenberg Repository.Why?
Before this update all the bundled files referenced the schema of the trunk branch. Because of that it was not possible to validate changes to the schema in the local files. With this update any changes you make to the schema directly get validated right on the bundled files.
How?
Changing the
$schemafromhttps://schemas.wp.org/trunk/theme.jsonto a relative file path pointing toschemas/json/theme.json