Skip to content

Interactivity API: Try this in callbacks for async actions#61098

Closed
sirreal wants to merge 2 commits into
trunkfrom
try/interactivity-async-callback-via-this
Closed

Interactivity API: Try this in callbacks for async actions#61098
sirreal wants to merge 2 commits into
trunkfrom
try/interactivity-async-callback-via-this

Conversation

@sirreal

@sirreal sirreal commented Apr 25, 2024

Copy link
Copy Markdown
Member

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Comment thread packages/interactivity/src/store.ts Outdated
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
@sirreal

sirreal commented Apr 26, 2024

Copy link
Copy Markdown
Member Author

I don't think this is a viable solution because getContext inside state getter functions will still be wrong, and that's a very common pattern based on my experience.

See #53586 (comment)

@sirreal sirreal closed this Apr 26, 2024
@sirreal sirreal deleted the try/interactivity-async-callback-via-this branch April 26, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants