@mirka @tyxla can you help me figure out what I need to look into to make sure this upgrade can safely ship? I don't wanna miss anything.

Linking this comment where some of this was already discussed: #60897 (comment)

What we usually do is:

• Check the Ariakit changelog for things that might affect us, and smoke test any affected components.
• Address any test failures.

What we usually do is:

• Check the Ariakit changelog for things that might affect us, and smoke test any affected components.
• Address any test failures.

What Lena said. The ariakit changelog is usually pretty thorough. I'd devote special attention to the breaking changes there, although there might be something unintentionally breaking.

As we also discussed earlier today, many of our components don't use Ariakit, so the impact of the update won't be as if every component uses Ariakit under the hood.

Looks like most of the failing tests are due to a change on data-* attributes: Public data attributes have now boolean values

Also, tooltips no longer assign aria-labelledby/aria-describedby attributes: ariakit/ariakit#3318

Other failures appear to prompt act warnings, potentially indicating an internal change in sync/async stuff. Typically, replacing getBy with findBy, or waitFor a change on the screen before making an assertion resolves the problem. Alternatively, you can use @ariakit/test events, which may also be beneficial and prevent these warnings from recurring since it doesn't depend on act. More context: #54225 (comment)

Thank you very much @diegohaz :)

I had parked this PR for a bit to focus on other stuff but your insights are gonna be super helpful as I come back to it (soon).

hey @DaniGuardiola , do you think you'll be able to resume work on this? It would be good to have the latest version while wrapping up the rewrite of CustomSelectControl and DropdownMenu

@ciampo alright, that's a great reason to bump this in my priority list 👍

Moved to main repo, see #62947