fix: add types to useSuspenseSelect#60733
Merged
jsnajdr merged 3 commits intoWordPress:trunkfrom Apr 15, 2024
Merged
Conversation
This commit use existing types to more completely type the `useSuspenseSelect` hook. Using a generic `MapSelect` type for the argument and it's return type will provide exact typings of the provided `select` function when using a typed data store object.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jsnajdr
approved these changes
Apr 15, 2024
Member
jsnajdr
left a comment
There was a problem hiding this comment.
Yes, this is nice. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the types of the
useSuspenseSelecthook.Why?
The current typing of
useSuspenseSelectis very basic, and does not use the existing types ofuseSelect. By using them we can provided better information about the returned data.How?
Using a generic
MapSelecttype for the argument and it's return type provide exact typings of the providedselectfunction when using a typed data store object.