Block Bindings: Support for editing in block bindings#60719
Closed
SantosGuillamot wants to merge 3 commits intotrunkfrom
Closed
Block Bindings: Support for editing in block bindings#60719SantosGuillamot wants to merge 3 commits intotrunkfrom
SantosGuillamot wants to merge 3 commits intotrunkfrom
Conversation
|
Size Change: +120 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Apr 13, 2024
| registry.batch( () => { | ||
| updatedSetAttributes( newAttributes ); | ||
| } ); | ||
| } } |
Member
There was a problem hiding this comment.
We could probably move batching into updatedSetAttributes?
Member
There was a problem hiding this comment.
Because now you're passing a new function as setAttributes all the time.
ellatrix
reviewed
Apr 13, 2024
| if ( attribute in updateFunctions ) { | ||
| updateFunctions[ attribute ]( value, nextAttributes ); | ||
| } else { | ||
| setAttributes( nextAttributes ); |
Member
There was a problem hiding this comment.
This should move outside the for loop
Member
There was a problem hiding this comment.
And remove the attribute keys not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP DESCRIPTION
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast