[Mobile] - Crash fixes when pasting HTML content#60676
Merged
Conversation
added 6 commits
April 11, 2024 17:00
2 tasks
|
Size Change: -18 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
This was referenced Apr 11, 2024
# Conflicts: # packages/react-native-editor/CHANGELOG.md
|
Flaky tests detected in 39cf61f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8754892767
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
Addresses some of the issues in #55652
Why?
To prevent the editor from crashing in some cases where users paste content from other text editors like Microsoft Word.
How?
By addressing two of the issues listed in #55652
special-comment-converterFor this case it adds the
datasetpolyfill as we did for other cases, it has the basic functionality to set/getdataattributes.It also enables the tests for this filter.
image-correctorFor this filter, it updates the native variant bringing some parts of the web's code to clear the
srcvalue if the image tag has afilevalue.Testing Instructions
Note
Please use the following builds to test:
special-comment-converterHTML
image-correctorHTML
Testing Instructions for Keyboard
N/A
Screenshots or screencast
special-comment-converterSpecialCommentBefore.mov
SpecialCommentAfter.mov
image-correctorImageCorrectorBefore.mov
ImageCorrectorAfter.mov