Editor: Add wordcount and reading time info in post card#60672
Merged
ntsekouras merged 6 commits intoApr 15, 2024
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
7 tasks
|
Size Change: +1.25 kB (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Apr 11, 2024
mcsf
left a comment
Contributor
There was a problem hiding this comment.
Preemptively approved, but please see my notes :)
Member
|
So we're now just showing the same information in two places? 🤔 
|
Contributor
Author
Yes, but the goal is to add this info in the post card. We could consider removing them from |
Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com>
swissspidy
reviewed
Apr 11, 2024
Contributor
|
@ntsekouras perhaps the wordcount/time to read should be separate from the modified date since they are not directly related: 
I also noticed that the ellipsis button in this panel is using the |
swissspidy
reviewed
Apr 11, 2024
| { sprintf( | ||
| /* translators: 1: How many words a post has (e.g. 30 words). 2: the number of minutes of read time (e.g. 2 minutes read time) */ | ||
| /* translators: %1s: is the number of minutes. */ | ||
| '%1$s, %2$s.', |
Member
There was a problem hiding this comment.
Usually such strings just containing placeholder are not really useful for translators.
Could we maybe move it around a little bit?
%1$s. %2$s read time.
Contributor
There was a problem hiding this comment.
Usually such strings just containing placeholder are not really useful for translators.
This was initially my suggestion, based on the idea that translators ought to decide which, if any, punctuation should best separate the two fragments. Of course, in a non-numerical setting this could all be a single string, e.g. __( '%1$s words, %2$s reading time.' ), but since we need to take care of number agreement foremost this seemed like a reasonable concatenation technique.
Member
There was a problem hiding this comment.
With something like %1$s. %2$s read time. we can still deal with the numbers in the individual strings, e.g. %1$s is _n( '%s word', '%s words' and %2$s here is _n( '%s minute', '%s minutes' )
Contributor
|
I'd make sure there is a clear comment for all read times. As a polyglot, I have seen too many times that translators translate e.g. "sec read" too literal. When you do that in Dutch for example, you get something like you read how many seconds it has been or you get something you expect on a report like "He has read for 5 seconds". |
jameskoster
approved these changes
Apr 12, 2024
jameskoster
left a comment
Contributor
There was a problem hiding this comment.
We can finesse the design further in follow-ups.
Thanks for updating the button size :)
tobifjellner
left a comment
Contributor
There was a problem hiding this comment.
I'd suggest that you make it possible for translators to assign a different value of AVERAGE_READING_RATE for their locale. Something like
//translators: This value together with the translation of xxx
_x('189', 'Value of AVERAGE_READING_RATE',...
Contributor
Author
This seems out of scope of this PR as It seems the feedback has been addressed and I'll land this. I can open a follow up if someone thinks there is a better handling of the translation message. |
youknowriad
reviewed
Apr 15, 2024
youknowriad
reviewed
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of: #59689
This PR add the wordcount and reading time info in post card, which are already part of the details view in site editor.
Testing Instructions
Screenshots or screencast