Update: Move template actions to the editor store.#60395
Merged
jorgefilipecosta merged 11 commits intoApr 11, 2024
Conversation
|
Size Change: -288 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
e0c5238 to
826b965
Compare
|
Flaky tests detected in d763c671f58480cbf0e4aac69ecba3e236ff6bf9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8602162792
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
23ffe3a to
57f457c
Compare
e44d04d to
454d2a0
Compare
mcsf
approved these changes
Apr 11, 2024
mcsf
left a comment
Contributor
There was a problem hiding this comment.
Left some notes and a recommendation, but other than that LGTM!
Comment on lines
+133
to
+134
| async ( { registry } ) => { | ||
| await unlock( registry.dispatch( editorStore ) ).removeTemplates( [ |
Contributor
There was a problem hiding this comment.
(minor question) Is the async/await structure necessary here? We're just delegating to a private action, so I'd've expected something like removeTemplate = tpl => unlock( ... ).removeTemplates( [ tpl ] ). Or is it to signal something to the reader?
Member
Author
There was a problem hiding this comment.
Yes, we can just return and I updated the code. But it is a fact that async await provides a better signal to the reader that the action is async, but we don't do it in other parts of the code so we can just return here as well.
| "@wordpress/compose": "file:../compose", | ||
| "@wordpress/core-data": "file:../core-data", | ||
| "@wordpress/data": "file:../data", | ||
| "@wordpress/data-controls": "file:../data-controls", |
Member
Author
There was a problem hiding this comment.
The IDE automatically added a wrong import the line was removed.
| }, | ||
| }; | ||
|
|
||
| export const resetTemplateAction = { |
Contributor
There was a problem hiding this comment.
(I don't remember if I have already asked this question) Why are we exporting these actions? Unless there is a present need, let's hide them and only expose usePostActions, no?
Member
Author
There was a problem hiding this comment.
Yes, I missed this on the other PR, the exports were removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #60092.
This PR moves the template actions to the editor package.
It will allow actions like reverting a template to be available on the post editor (the post card panel at the top when editing the template will show the actions).
To move the "template actions" two store actions also needed to be included in the editor package.
Testing
Open the templates section and verify actions and bulk actions still work as before.