test: Fix Rich Text failures#60290
Merged
dcalhoun merged 2 commits intotry/quote-cite-buttonfrom Mar 28, 2024
Merged
Conversation
Prevent cryptic test failure messages originating from invoking this undefined method, which prevented the original error message from surfacing in the test failure log.
This export was added for interoperability with the web version modified in #58916.
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fluiddot
reviewed
Apr 1, 2024
| jest.mock( '@wordpress/react-native-bridge', () => { | ||
| return { | ||
| addEventListener: jest.fn(), | ||
| logException: jest.fn(), |
Contributor
There was a problem hiding this comment.
Good catch! Since this function is only invoked when there's an error, we overlooked adding it because unit tests were passing. Thanks @dcalhoun for fixing it 🙇 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Address test failures and compatibility between web and native rich text
components.
Why?
Enable code sharing between platforms, namely the Quote block presently.
How?
Define missing
logExceptionnative module mock that masked the actual testfailures.
Export a private API Rich Text module for interoperability with the web version,
which was modified in #58916.
Testing Instructions
Ensure no regressions occur when interacting with rich-text-powered blocks.
Verify the Quote block citation is toggled by a button in the block toolbar.
Testing Instructions for Keyboard
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.