i18n: Use the WordPress package and remove the built-in implementation#6007
Merged
youknowriad merged 2 commits intomasterfrom Apr 10, 2018
Merged
i18n: Use the WordPress package and remove the built-in implementation#6007youknowriad merged 2 commits intomasterfrom
youknowriad merged 2 commits intomasterfrom
Conversation
f979748 to
0c094ee
Compare
aduth
reviewed
Apr 9, 2018
| "eslint-plugin-jsx-a11y": "6.0.2", | ||
| "eslint-plugin-react": "7.7.0", | ||
| "extract-text-webpack-plugin": "4.0.0-beta.0", | ||
| "gettext-parser": "1.3.0", |
Member
There was a problem hiding this comment.
We should also remove babel-traverse (used only in the plugin's tests).
Contributor
Author
|
Any other concern here? |
Member
|
Sorry for not being able to answer on time.
Yes, this is awesome. :) Once we are done with all updates to Babel config (I saw other PR touching it), I will spin PR in packages to find a way to move it there 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5984
This PR updates Gutenberg to use the npm published i18n package.
It removes the built-in implementation of the package and all the related tools (babel-plugin, pot-to-php).
Testing instructions
npm run package-pluginnotice the pot and the php files are included properly in the generated zip.