Revert shadow.defaultPresets default to true#60000
Closed
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Closing in favor of #60204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/60815
WP Dev PR: WordPress/wordpress-develop#6295
What?
Reverts the core
settings.shadow.defaultPresetsback totrue.Why?
Fixes #59989
Themes should not change appearance with just a WP update. We have a migration mechanism for theme.json to allow for theme authors to change default values that should be used if we want to change a default.
All of the
default*settings have beentrueby default as they've been added, so this brings consistency to that again as well.How?
settings.shadow.defaultPresetstotruein lib/theme.json.array( 'shadow', 'defaultPresets' )fromAPPEARANCE_TOOLS_OPT_INSas it is no longer needed when we havetrueby default.editor-shadow-presetsanddefault-shadow-presetstheme supports for classic themes to match how colors/gradients presets work.Testing Instructions
Block themes
Here is an example theme.json for testing that would override the default
naturalshadow with a red shadow to make the difference obvious.wp/6.4trunkwp/6.4and this PR match.Classic themes
TODO: Finish writing testing scenarios.
Test disabling shadow presets.
Test custom shadow presets.
Test disabling default shadow presets.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Block themes
WP 6.4
Current 6.5 (
"defaultPresets": false)This PR (
"defaultPresets": true)Classic themes
TODO: Screenshots of UI for classic themes in each of the testing scenarios.