Skip to content

Added @global to PHP Docs Comments#59725

Merged
t-hamano merged 2 commits into
WordPress:trunkfrom
shail-mehta:add-global-to-php-docs
Mar 9, 2024
Merged

Added @global to PHP Docs Comments#59725
t-hamano merged 2 commits into
WordPress:trunkfrom
shail-mehta:add-global-to-php-docs

Conversation

@shail-mehta

@shail-mehta shail-mehta commented Mar 9, 2024

Copy link
Copy Markdown
Member
  • Added @global in php docs comments
  • Added @since before @param & @return according to PHP Doc Standards

Fixes: #59724

@github-actions

github-actions Bot commented Mar 9, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think there needs to be a change regarding periods, but I think this change makes sense.

Comment thread lib/client-assets.php Outdated
Comment thread lib/compat/wordpress-6.5/scripts-modules.php Outdated
@t-hamano t-hamano added the [Type] Code Quality Issues or PRs that relate to code quality label Mar 9, 2024
@t-hamano

t-hamano commented Mar 9, 2024

Copy link
Copy Markdown
Contributor

Note: Core already adds the @global annotation, so no backport is needed.

@shail-mehta shail-mehta requested a review from t-hamano March 9, 2024 09:12

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@t-hamano t-hamano merged commit 3b42812 into WordPress:trunk Mar 9, 2024
@github-actions github-actions Bot added this to the Gutenberg 18.0 milestone Mar 9, 2024
@shail-mehta shail-mehta deleted the add-global-to-php-docs branch April 7, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants