Remove scrolling of empty image blocks.#59305
Merged
fabiankaegy merged 4 commits intotrunkfrom Feb 23, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +67 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
fabiankaegy
requested changes
Feb 23, 2024
Member
fabiankaegy
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Whilst the solution you added here works, it is too broadly applied. Currently this style update here applies to all instances of the Placeholder component. Which is used by many blocks in many instances.
Instead of making this change here in the placeholder component CSS this should be done in the editor.css file of the imabe block scoped to only apply to the placeholder nested inside an image block
|
Flaky tests detected in 7cfd5a8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8016251353
|
Member
Author
|
@fabiankaegy Thank you for reviewing! Fixed to be controlled by editor.css in the image block. |
fabiankaegy
approved these changes
Feb 23, 2024
Member
fabiankaegy
left a comment
There was a problem hiding this comment.
This now works as expected :) thanks!
Contributor
|
I believe this PR caused a regression, so that the image block now features a layout shift when selected. Before this PR:
After:
I'll see if I can spin up a PR. |
Contributor
|
Alternative fix here: #59857 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove scrolling of empty image blocks.
Why?
Fix #59226.
How?
Show
.components-placeholder__fieldsetonlyis-selected.Testing Instructions
It seems easiest to produce with the 'Team members' pattern that's included with WordPress 6.4/6.5 by default.
Testing Instructions for Keyboard
Screenshots or screencast