Font Library: make font collection fields translatable#59256
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-collections-controller.php ❔ lib/compat/wordpress-6.5/fonts/fonts.php |
|
Flaky tests detected in c79602f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8002415091
|
There was a problem hiding this comment.
All of these strings need the 'gutenberg' text domain as well.
@pbking yes, that's expected. |
creativecoder
left a comment
There was a problem hiding this comment.
Thanks for adding the domain to the new text strings.
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
450f9f5 to
c79602f
Compare
|
I rebased this and now hopefully all the tests will be ✅ and auto merge will handle. |

What?
Porting changes back from WordPress core PR already merged: WordPress/wordpress-develop#6130