Skip to content

Theme docs: Update appearance-tools docs to reflect opt-in for backgroundSize and aspectRatio#59165

Merged
fabiankaegy merged 1 commit intotrunkfrom
update/appearance-tools-docs-to-include-background-size
Feb 19, 2024
Merged

Theme docs: Update appearance-tools docs to reflect opt-in for backgroundSize and aspectRatio#59165
fabiankaegy merged 1 commit intotrunkfrom
update/appearance-tools-docs-to-include-background-size

Conversation

@andrewserong
Copy link
Copy Markdown
Contributor

What?

Add references to backgroundSize and a missing reference to aspectRatio to theme documentation related to appearanceTools.

Why?

With backgroundSize being included in WP 6.5 and being opted-in via appearanceTools, we should reflect this in the docs.

How?

Update the theme.json schema, and the two places in the docs that refer to appearance tools (I think there's only two places, but there could potentially be more).

Testing Instructions

Double-check spelling.

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Flaky tests detected in 247e3fe.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7955166218
📝 Reported issues:

Copy link
Copy Markdown
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update :)

@fabiankaegy fabiankaegy merged commit b452848 into trunk Feb 19, 2024
@fabiankaegy fabiankaegy deleted the update/appearance-tools-docs-to-include-background-size branch February 19, 2024 06:53
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants