[RNMobile] Prevent JavascriptException on scrollToSection#59110
Merged
derekblank merged 2 commits intoFeb 19, 2024
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 2d0a1c9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7925267275
|
fluiddot
approved these changes
Feb 16, 2024
fluiddot
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🎊 ! Thanks @derekblank for addressing the issue 🙇 !
I couldn't manage to reproduce it without changing the code. My gut feeling is that the following part might be related, although rotating the device and adding a block at the same time works without any issues. The fact that it only affected a few users makes me think that the scenario for the crash to happen is an edge case.
Member
Author
|
Thanks for taking a look!
I agree that the linked code seems like the source of |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes:
Why?
Prevents fatal JavascriptException from firing when
scrollToSectionis invoked.How?
Checks if the property
currentexists on thescrollViewMeasurementswithin thescrollToSectionhook.Testing Instructions
To test in general, create a situation where the app invokes
scrollToSectionhook, and observe the app does not crash. This can be done by following the Testing Instruction steps from #57273, or by the steps below: