Template Part: Fix site editor error when loading with list view set to always display#58868
Merged
andrewserong merged 1 commit intoFeb 9, 2024
Conversation
…to always display
|
Size Change: +3 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 71087df. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7838377238
|
tellthemachines
approved these changes
Feb 9, 2024
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for fixing this! Loading the site editor with list view always visible no longer errors.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Thanks for the quick review! 🙇 |
Member
|
Thank you, @andrewserong! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follows #58644
Fix a site editor error when opening the site editor with the list view set to always display ("Always open list view" in preferences)
Why?
When initially loading, until an entity object is properly resolved, the entity object appears to be an empty object, so
capitalCasewas being called withundefinedwhich throws an error.How?
If
entity.slugis not present, fallback to an empty string to avoidcapitalCasethrowing an errorTesting Instructions
In the site editor, open the preferences and set
Always open list viewand then do a full page reload the site editor in canvas mode, i.e:/wp-admin/site-editor.php?canvas=editOn
trunkif your template has Header or Footer template parts, there'll be an error.With this PR applied there should be no error
Testing Instructions for Keyboard
Screenshots or screencast
The error: