CustomSelect: add tests for new features#58583
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
approved these changes
Feb 2, 2024
Member
mirka
left a comment
There was a problem hiding this comment.
I had a few thoughts, but no blockers 👍
And thanks for the note in the description about toHaveTextContent — it was helpful!
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
ciampo
reviewed
Feb 3, 2024
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/custom-select-control-v2/test/index.tsx
Outdated
Show resolved
Hide resolved
81e9fd8 to
1861978
Compare
6 tasks
c04010f to
6ea8733
Compare
6ea8733 to
95a9882
Compare
ciampo
approved these changes
Feb 6, 2024
Contributor
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
We can always iterate in follow-up PRs with more tests as needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I planned to add additional tests for the new component once #57902 is merged. However, I think it would be good to do this before for additional checks that the new features continue to work.
Why?
To ensure new features work as intended and future changes like the legacy adapter don't break these features.
How?
Adding tests for features that aren't included in
CustomSelectControl(which will be included in this component's tests, after merging #57902).Note
We were hoping with the ariakit version we could improve tests so instead of
toHaveTextContentwe would asserttoHaveValue. However, there isn't avalueattribute since it's not an HTML input. We could consider adding a data attribute if that would be better than checking the option's text content.Testing Instructions
npm run:test packages/components/src/custom-select-control-v2/test/index.tsx