Closed
Conversation
3 tasks
Contributor
|
@gaambo Yes, the phpcs tests don't seem to fail for these (in both Gutenberg and core) |
youknowriad
approved these changes
Jan 29, 2024
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
I guess some of these files will be changed with the timeout fixes
Contributor
Author
|
Changes were incorporated in #58389. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates fixes some code formating errors from merging gutenberg into core.
See:
WordPress/wordpress-develop#5922 (comment)
WordPress/wordpress-develop#5922 (comment)
Additionally, the rest of the file (
navigation-link/index.php) andpost-terms/index.php(since it was changed in similar manners because of the WP_Block_Type::$variations changes) were checked and fixed as well.Question: Any way to check for these coding standards locally? I was running
npm run lint:phpbut it never complained about those - are those some core only style guides which don't get enforced in Gutenberg?