Framework: Remove deprecations slated for 2.5.0 removal#5833
Conversation
blocks/library/paragraph/index.js
Outdated
There was a problem hiding this comment.
Is key necessary here?
There was a problem hiding this comment.
Is key necessary here?
Nope. Mistaken copy from the migrate function.
blocks/rich-text/editable.js
Outdated
There was a problem hiding this comment.
Should we change it in deprecated.md as well?
There was a problem hiding this comment.
Should we change it in
deprecated.mdas well?
Yep. Added.
blocks/library/paragraph/index.js
Outdated
There was a problem hiding this comment.
We still have an instance of string saving in the parser's unit test but I'm certain it's used at all.
There was a problem hiding this comment.
We still have an instance of string saving in the parser's unit test but I'm certain it's used at all.
Technically it's not really a problem that a save returns a string, just that previously we would treat it as unescaped, and now it's subject to React render serialization (now equivalent to returning a string from a component).
Documentation page is still active, despite having been removed: https://wordpress.org/gutenberg/handbook/block-api/editable-api/
bd63414 to
dd0b2e1
Compare
This pull request seeks to remove deprecations slated for removal in the upcoming 2.5.0 release.
Specifically, this includes:
savewp.data.querywp.blocks.Editablewas slated for removal as well, but since the Editable API is still (mistakenly) documented on the Gutenberg handbook, I'm inclined to continue to push this to being removed in a future release.This also updates a the unwrapped paragraph deprecation approach implemented in #4874 to correctly use
RawHTMLin the deprecatedsave. This issue became obvious with the removal thanks to existing fixture tests.Testing instructions:
Verify that there are no regressions in impacted behavior, and importantly that no references to deprecated behaviors exist in core code.