Conversation
fluiddot
approved these changes
Jan 19, 2024
Contributor
fluiddot
left a comment
There was a problem hiding this comment.
LGTM 🎊 !
I built and tested the Gutenberg demo app successfully. Additionally, I confirmed that the GBM library was made and published successfully via wordpress-mobile/gutenberg-mobile#6559.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out of abundance of caution, we are updating the group id that we use to publish the Android artifacts from
org.wordpress-mobiletoorg.wordpressas we don't own thewordpress-mobile.orgdomain. This will also make it more consistent with every other WordPress Android artifact that's published to Automattic's S3 Maven.The
react-native-librarieschange has been made here: wordpress-mobile/react-native-libraries-publisher#32