Data views table layout: Update cell vertical alignment#57804
Merged
ntsekouras merged 1 commit intotrunkfrom Jan 15, 2024
Merged
Data views table layout: Update cell vertical alignment#57804ntsekouras merged 1 commit intotrunkfrom
ntsekouras merged 1 commit intotrunkfrom
Conversation
|
Size Change: +83 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 53fff0f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7502803466
|
4 tasks
ntsekouras
reviewed
Jan 19, 2024
| { field.render( { | ||
| item, | ||
| } ) } | ||
| <span className="dataviews-view-table__cell-content-wrapper"> |
Contributor
There was a problem hiding this comment.
I now realised that we cannot have an inline element(span) as a wrapper because it creates invalid html.
The addition of styling this as display:flex too, make the previews not render because of the width calculation.
Can we achieve what this PR does without spans and make sure the previews are displayed properly?
Sorry for not catching this earlier..
Contributor
Author
There was a problem hiding this comment.
We actually have an issue to remove the template previews in Table and List layouts. They're just too small to be effective in those layouts. Does that affect things here at all?
The wrapping element doesn't really matter I think... would a div work? Or are you suggesting to remove the wrapper entirely? I couldn't think of a way to achieve the desired result (see the "After" screenshot) without one, did you have an idea?
Contributor
There was a problem hiding this comment.
I created a follow up which will need some eyes from you :). Regarding the removal of the preview, let's handle this separately as we need to support it in general, even if we decide to remove it from these specific pages now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Align contents of table cells
toprather thanmiddle.Why?
Top alignment works better when there are cells that grow in height, e.g. the "Description" field in the templates table.
How?
vertical-align: topto.dataviews-view-table tbody td.min-heightequal to the tallest element in each row (action buttons). This enables pseuso-middle-alignment when there are no cells that grow in height.Testing Instructions
Screenshots or screencast
Note that the first 5 rows have the same appearance before and after, but in the rows with long descriptions cell contents are aligned with one another at the top of the row.