Fix Widgets page Undo and Redo accessibility and keyboard interaction#57677
Merged
Fix Widgets page Undo and Redo accessibility and keyboard interaction#57677
Conversation
|
Size Change: +16 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
2491901 to
e0685c5
Compare
draganescu
approved these changes
Jan 11, 2024
Contributor
draganescu
left a comment
There was a problem hiding this comment.
This tests very well, the buttons remain focusable even when disabled. The code looks great, thank you 👏🏻
Contributor
Author
|
Thanks for the review 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57647
What?
Why?
How?
It appears that the Undo and Redo buttons need to use
forwardRefto correctly handle the aria-disabled attribute instead ofdisabled. Also, arrow keys navigation needs to dynamically settabindex="-1"on all the toolbar buttons except the one that is currently focused. This doesn't seem to work correctly withoutforwardRef.I guess something needs to be passed to the underlying Button element but honestly I don't understand why
forwardRefis necessary. I would appreciate someone more familiar with this to have a look.This PR basically mimics the editor package EditorHistoryUndo and EditorHistoryRedo implementation but it's not clear at all to me why
forwardRefis needed.More importantly: I would expect that when using
ToolbarItem,ToolbarButton, orToolbarDropdownMenuin aNavigableToolbarthe toolbar works as expected out of the box, handlingaria-disablednad arrow keys navigation out of the box. This doesn't seem to be the case and it makes using these components pretty confusing. It's not clear at all how to use them and have the expected behavior working correctly.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast