Migrate 'taxonomies' e2e tests to Playwright#57662
Merged
Merged
Conversation
Mamaduka
commented
Jan 9, 2024
| } | ||
|
|
||
| const tagName = 'tag-' + generateRandomNumber(); | ||
| const tags = page.locator( '.components-form-token-field__token-text' ); |
Member
Author
There was a problem hiding this comment.
I couldn't find a better locator here. The screen readers use the Remove Tag button and its description, but PW currently can't locate elements based on descriptions.
Some workarounds are described in microsoft/playwright#18332, but decided to go with the simplest solution.
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Jan 9, 2024
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
I left only one comment, but LGTM 👍
| await page | ||
| .getByRole( 'button', { | ||
| name: 'Add New Category', | ||
| expanded: false, |
Contributor
There was a problem hiding this comment.
This line seems unnecessary.
Member
Author
There was a problem hiding this comment.
The panel has two Add New Category buttons; the first expands the form, and the second submits. I added the expanded check as a safeguard and to highlight the intention.
Screenshot
Contributor
There was a problem hiding this comment.
Oh, I missed that 😅 If so, there is no problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
taxonomies.test.jse2e tests to Playwright.Why?
See #38851.
Notes
if the user has the right capabilitiessuffixes andcanCreatTermInTaxonomychecks. The tests currently only run for admin users which have the capabilities.Testing Instructions