Paragraph: store subscription for selected block only#56967
Merged
Conversation
|
Size Change: +81 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f8e2b8c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7178178106
|
youknowriad
reviewed
Dec 12, 2023
| </InspectorControls> | ||
| ) } | ||
| <InspectorControls group="typography"> | ||
| <DropCapControl |
Contributor
There was a problem hiding this comment.
So you think the useSetting call is more expensive than rendering InspectorControls?
Contributor
There was a problem hiding this comment.
oh the useSetting is only done for the selected block now. Makes sense.
Member
Author
There was a problem hiding this comment.
Yes, because (1) drop cap is supported by default and (2) individual InspectorControls instances no longer make select calls but read from context instead, so they're much cheaper.
youknowriad
approved these changes
Dec 12, 2023
Contributor
|
Creative. :) |
This was referenced Nov 19, 2024
This was referenced Dec 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I know changing block for performance is generally frowned upon, but hear me out:
ParagraphRTLControl.InspectorControlsorBlockControlsso it's only for the select block: for example list item'sIndentUI.Why?
Every useSelect added to a (frequestly used) block will degrade the load and type bit. By moving it within InspectorControls, the subscription is now only added for the selected block(s).
How?
Moving it with InspectorControls ensures it's only added when the block is selected.
Testing Instructions
Load (first block)
First run: -4.25%
Second run: -3.85%
Testing Instructions for Keyboard
Screenshots or screencast