Fix wrong type for receiveNavigationFallbackId#56830
Closed
widoz wants to merge 3 commits intoWordPress:trunkfrom
Closed
Fix wrong type for receiveNavigationFallbackId#56830widoz wants to merge 3 commits intoWordPress:trunkfrom
receiveNavigationFallbackId#56830widoz wants to merge 3 commits intoWordPress:trunkfrom
Conversation
The `integer` type does not exists on TypeScript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
integertype does not exists on TypeScript.What?
Fixing TypeScript type for the function
receiveNavigationFallbackIdwhere the type for thefallbackIdis specified asintegerbut it shall benumbersince the former does not exists in TypeScript.Why?
Correctly type the function
How?
Correct the function signature
Testing Instructions
Nothing to specify
Testing Instructions for Keyboard
Nothing to specify
Screenshots or screencast