Build: Dynamically pick JS/CSS build files for ZIP gen#5664
Merged
Conversation
3 tasks
mcsf
commented
Mar 19, 2018
bin/build-plugin-zip.sh
Outdated
| blocks/library/*/*.php \ | ||
| post-content.js \ | ||
| $vendor_scripts \ | ||
| {blocks,components,date,editor,element,hooks,i18n,data,utils,edit-post,viewport}/build/*.{js,map} \ |
Contributor
Author
There was a problem hiding this comment.
I don't believe the *.{js,map} bit was up-to-date. In any case, we don't expect .map files in the ZIP file, to my knowledge. Hence my removal.
7a98897 to
ec18afa
Compare
aduth
approved these changes
Mar 20, 2018
Member
aduth
left a comment
There was a problem hiding this comment.
👍
Rebased to resolve conflicts.
While this makes bundling less intentional (we were previously targeting specific folders where we expect CSS to exist), I think it lends to better overall maintainability.
Contributor
Author
Agreed. I can see this sort of work progress into clearly defining our entry points and leveraging said definition throughout the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sparked by #5430 (comment), this aims to reduce the need for manual synchronization between
webpack.config.js,bin/build-plugin-zip.sh,.eslintrc.js, and any other place where knowledge of which entry points Gutenberg has is needed.To keep it short, this PR only targets
bin/build-plugin-zip.shand uses the shell's**file expansion.Previously
An initial exploration saw the creation of a small
bin/list-entry-points.jsscript which readwebpack.config.js(thus treating it as the canonical source for entry-point information) and roughly did:How Has This Been Tested?
Run
./bin/build-plugin-zip.sh. Make sure no errors are found. Inspect the generated ZIP file. Compare its manifesto (e.g.unzip -l <file>) with the one from the latest release or one generated frommaster.Screenshots (jpeg or gifs if applicable):
Types of changes
Checklist: