Block Editor: Fix typo in URLInput's onKeyDown prop documentation#56322
Merged
t-hamano merged 1 commit intoWordPress:trunkfrom Nov 21, 2023
Merged
Block Editor: Fix typo in URLInput's onKeyDown prop documentation#56322t-hamano merged 1 commit intoWordPress:trunkfrom
URLInput's onKeyDown prop documentation#56322t-hamano merged 1 commit intoWordPress:trunkfrom
Conversation
Before: onKeydown After: onKeyDown
URLInput's onKeyDown prop documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This pull request updates the URLInput component to correctly handle keyboard events. The prop onKeydown is changed to onKeyDown to ensure that keyboard events are captured as intended.
Why?
While using the URLInput component, I noticed that the onKeydown function was not triggered upon key presses. After investigating, I found that the correct React prop should be onKeyDown. This change is necessary for the component to respond to keyboard events.
not work
work
<URLInput value={ link || '' } onChange={ ( value ) => onSetLinkHandler( value ) } - onKeydown={ ( + onKeyDown={ ( event: KeyboardEvent ) => { console.log( event ); } } />How?
The change is a simple update in the component's props, replacing onKeydown with onKeyDown. This aligns with the standard React event naming conventions and ensures that the component's event handling functions as expected.
Testing Instructions
Testing Instructions for Keyboard
To test using only the keyboard:
Screenshots or screencast