Update Labels in Block Inserter (block patterns tab)#55986
Merged
Conversation
Update two labels to Title Case
|
Size Change: +206 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
richtabor
requested changes
Nov 9, 2023
Member
richtabor
left a comment
There was a problem hiding this comment.
I suppose "Call to Action" should be "Call to action", rather than changing the title case of the menu items for patterns. I suppose "All patterns" could be just "All" though.
Sentence case is used prominently throughout the UI:
Member
|
Thoughts @WordPress/gutenberg-design? |
Contributor
|
Since sentence case (with capitals for proper nouns) is the standard, so good catch on the inconsistencies. Per the latest change, it appears we have "All" and "My patterns". Agreed also that "Call to Action" should be sentence case, but that can be separate if need be? Otherwise, 👍 👍 |
richtabor
approved these changes
Nov 13, 2023
Contributor
Author
|
I'm not sure why the End-to-End Test has failed for this adjustment. What's required to resolve this? |
Contributor
Was a failure unrelated to this PR - I reran the test and it passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Patterns tab of the Block Inserter I have amended the labels for 'My patterns' and 'All patterns' to 'My Patterns' and 'All Patterns' (title case). I believe this is a more consistent approach, also I see further down we have 'Call to Action' pattern category which is title case.
What?
Adding title case for two labels
Why?
A more professional, consistent edit
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast