[WIP] Design Tools: Add section specific block type styles#55563
Closed
aaronrobertshaw wants to merge 4 commits intotrunkfrom
Closed
[WIP] Design Tools: Add section specific block type styles#55563aaronrobertshaw wants to merge 4 commits intotrunkfrom
aaronrobertshaw wants to merge 4 commits intotrunkfrom
Conversation
6 tasks
Contributor
Author
|
Closing this in favour of #56234 |
7 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 🚧 🚧 This is a draft proof of concept and will be dusted off soon 🚧 🚧 🚧
Note: This branch needs rebasing and conflicts resolved.
What?
Adds new block support to facilitate application of section specific styles. These styles are stored within a container block's attributes and the style object. They are then treated as a theme.json partial and a stylesheet generated and enqueued from that.
Note: This has been abandoned in favour of #56234 so we can merge the concepts of color sets/colorways and section specific styling. Furthermore this will allow the section styles to be stored in theme.json and the global styles such that section styles can be re-used
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast