Writing Flow: Cancel isTyping when focusing non text field#5552
Merged
Writing Flow: Cancel isTyping when focusing non text field#5552
Conversation
| }; | ||
| } ), | ||
| withDispatch( ( dispatch ) => { | ||
| const { startTyping, stopTyping } = dispatch( 'core/editor' ); |
jorgefilipecosta
approved these changes
Mar 12, 2018
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
This seems to work as advertised and cancels the isTyping. The code looks good 👍
I noticed that when are not typing (the toolbar is visible in the paragraph) and we use the arrow down to go to the image. The image toolbar does not appear, this PR solves the case when we are typing so I think this scenario may also deserve an improvement in other PR as it is another case that may need to be handled.
Member
Author
|
Thanks @jorgefilipecosta . It looks like its an issue of focus being evaluated before keydown, so typing isn't stopped but the keydown handler proceeds to start typing. Adding a simple delay alleviates this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to cancel the
isTypingflag when focus transitions to a non-text element. This is particularly helpful for reactivating toolbars in elements which don't have text fields, where previously the toolbars only reactivate when the selection becomes uncollapsed.Testing instructions:
isTypingby navigating back into the paragraph block)