Skip to content

#53560 change button property "isSmall" to "size" on navigation menu-title#55503

Closed
tkc49 wants to merge 2 commits intoWordPress:trunkfrom
tkc49:fix/change-button-property-isSmall-to-size
Closed

#53560 change button property "isSmall" to "size" on navigation menu-title#55503
tkc49 wants to merge 2 commits intoWordPress:trunkfrom
tkc49:fix/change-button-property-isSmall-to-size

Conversation

@tkc49
Copy link
Copy Markdown

@tkc49 tkc49 commented Oct 20, 2023

What?

Fixed #53560

Why?

Because isSmall property is deprecated.

@tkc49 tkc49 requested a review from ajitbohra as a code owner October 20, 2023 07:16
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 20, 2023
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @tkc49! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Oct 20, 2023
@tkc49 tkc49 changed the title #53560 change button property "isSmall" to "size" #53560 change button property "isSmall" to "size" on navigation menu-title Oct 20, 2023
@skorasaurus
Copy link
Copy Markdown
Member

skorasaurus commented Nov 3, 2023

related PR: #53599 which replaces inSmall in several places, not just navigation block

@mirka
Copy link
Copy Markdown
Member

mirka commented Dec 18, 2023

Closing in favor of #53599, but there are a few more isSmall instances left in the codebase if you'd be available to address those 🙏

@mirka mirka closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Navigation Affects the Navigation Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button: Replace deprecated isSmall property with size="small" property

4 participants