Fix: Update page title when using enhanced pagination in query loop.#55446
Merged
cbravobernal merged 6 commits intotrunkfrom Oct 20, 2023
Merged
Conversation
|
Size Change: +29 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 10cddb4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6585212096
|
8a4e66d to
c734d75
Compare
luisherranz
reviewed
Oct 19, 2023
DAreRodz
requested changes
Oct 19, 2023
Contributor
DAreRodz
left a comment
There was a problem hiding this comment.
Almost there! Some changes need to be addressed, but they're pretty straightforward.
PS: Don't forget to fix the changelog as well! 😁
c734d75 to
10cddb4
Compare
DAreRodz
approved these changes
Oct 20, 2023
Contributor
DAreRodz
left a comment
There was a problem hiding this comment.
LGTM! Thank you, @c4rl0sbr4v0. 😊
Contributor
|
Cherry-picked for inclusion in 6.4 in 0d36390. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update the Document Title when the enhanced pagination is enabled on the Query Loop.
Why?
User experience :-).
To simulate a navigation, we should update page title, page description, and meta tags.
How?
By adding the tittle to the Interactivity API router.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2023-10-18.at.13.22.21.mov