[RNMobile] Synced Patterns: Ensure title is always visible#55399
Merged
Conversation
|
Size Change: 0 B Total Size: 1.66 MB ℹ️ View Unchanged
|
Contributor
Author
|
derekblank
approved these changes
Oct 20, 2023
derekblank
left a comment
Member
There was a problem hiding this comment.
I was able to follow the testing instructions successfully, LGTM! 🚀
I tried restarting the failing PHP tests as well -- I was able to get one previously-failing test to pass, but one is still failing. :| l checked the failures, and agree they seem flaky and unrelated to the changes in this PR. 👍
Contributor
@SiobhyB I've updated the PR with |
fluiddot
requested changes
Oct 20, 2023
|
Flaky tests detected in 6ac47e1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6586595900
|
fluiddot
reviewed
Oct 20, 2023
fluiddot
left a comment
Contributor
There was a problem hiding this comment.
I confirmed the changes work as expected by following the Testing Instructions 🎊 . I hold on my approval until we solve this issue.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #37203, by ensuring the title section of Synced Patterns is alway visible within the editor.
Why?
There are currently certain scenarios where the title section of Synced Patterns is invisible. This happens if a block-based theme with a light background is active, as the native editor displays the light background in contrast with the block's dark mode styles. The same happens if a theme has a dark background and a device's light mode if enabled.
How?
The logic associated with the title section's styles has been updated to use the block based theme's colour scheme.
Testing Instructions
Follow the preparation steps once for each mode (dark/light) and then proceed with the testing steps.
Preparation steps
Testing steps
Testing Instructions for Keyboard
N/A, solely a visual change.
Screenshots or screencast
Dark mode with light background
Light mode with dark background