Skip to content

HTML API: Backport updates from Core#55227

Merged
dmsnell merged 1 commit intotrunkfrom
html-api/backport-updates-from-core
Oct 10, 2023
Merged

HTML API: Backport updates from Core#55227
dmsnell merged 1 commit intotrunkfrom
html-api/backport-updates-from-core

Conversation

@dmsnell
Copy link
Copy Markdown
Member

@dmsnell dmsnell commented Oct 10, 2023

What?

Brings over already-merged and already-accepted updates to the HTML API from Core into Gutenberg's compatability layer.

Why?

Keeps the code in sync with each other and avoids mismatches between versions.

How?

"Blessed" backport.

Testing

Please ensure that the backport files are handled properly, and that the appropriate renaming has taken place.

@dmsnell dmsnell added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup labels Oct 10, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 10, 2023

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.4/html-api/class-gutenberg-html-tag-processor-6-4.php
❔ lib/compat/wordpress-6.4/html-api/class-wp-html-processor.php

This was referenced Oct 10, 2023
Closed
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 10, 2023 •
edited
Loading

Flaky tests detected in cf3b27f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6475244719
📝 Reported issues:

@dmsnell dmsnell changed the title HTML API: Backup updates from Core HTML API: Backport updates from Core Oct 10, 2023
@dmsnell
HTML API: Backup updates from Core
cf3b27f 
 - add `has_class()` and `class_list()` methods [#59209-trac](https://core.trac.wordpress.org/ticket/59209)
 - add `matches_breadcrumbs()` method [#59400-trac](https://core.trac.wordpress.org/ticket/59400)
 - rename `createFramgent()` to `create_fragment()` [#59547-trac](https://core.trac.wordpress.org/ticket/59547)
@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core branch from 8f178ba to cf3b27f Compare October 10, 2023 21:58
@dmsnell dmsnell merged commit cf3b27f into trunk Oct 10, 2023
@dmsnell dmsnell deleted the html-api/backport-updates-from-core branch October 10, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergeyBiryukov SergeyBiryukov SergeyBiryukov approved these changes

@ockham ockham Awaiting requested review from ockham

@westonruter westonruter Awaiting requested review from westonruter

@adamziel adamziel Awaiting requested review from adamziel

Assignees

No one assigned

Labels

Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmsnell @SergeyBiryukov