Merged
Conversation
|
Size Change: +451 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
ebdfaf6 to
2c2e1ce
Compare
glendaviesnz
approved these changes
Oct 12, 2023
Contributor
glendaviesnz
left a comment
There was a problem hiding this comment.
This tested well for me:
✅ Command was only available when on pattern summary and edit pages
✅ Pattern could be renamed using the command on both pattern summary and edit pages, and name change was immediately reflected in interface
✅ No name change was reflected if modal cancel button used
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
What?
Adds a command to rename a pattern when the currently edited entity is a pattern.
Note:
This PR lays the ground work for multiple patterns-related commands, e.g. duplicate pattern, which will be split into dependent PRs
Commands for renaming or duplicating template parts will be a further follow-up
Why?
Currently, renaming a pattern can only be done via the Patterns site editor grid view. Users should be able to quickly rename a pattern while editing or viewing the pattern.
How?
use-edit-mode-commandsto rename a patternTesting Instructions
Screenshots or screencast
Screen.Recording.2023-10-10.at.5.21.17.pm.mp4