Block parser updates based on removal of $empty_attrs#54770
Closed
dlh01 wants to merge 2 commits intoWordPress:fix/typesfrom
Closed
Block parser updates based on removal of $empty_attrs#54770dlh01 wants to merge 2 commits intoWordPress:fix/typesfrom
$empty_attrs#54770dlh01 wants to merge 2 commits intoWordPress:fix/typesfrom
Conversation
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
dmsnell
reviewed
Sep 25, 2023
Member
dmsnell
left a comment
There was a problem hiding this comment.
Seems good to me. thanks for pushing this out. I do think we need to add a note in the CHANGELOG for the package, and also probably for the default-parser as well.
| /* | ||
| * Fun fact! It's not trivial in PHP to create "an empty associative array" since all arrays | ||
| * are associative arrays. If we use `array()` we get a JSON `[]` | ||
| */ |
Member
There was a problem hiding this comment.
looks like we all missed this in WordPress/wordpress-develop#5049 - sorry!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the block parser docs and spec parser as requested here: https://core.trac.wordpress.org/ticket/59168#comment:7.
It builds on #54496, which removes the
\WP_Block_Parser::$empty_attrsproperty as also requested in that comment.Why?
See https://core.trac.wordpress.org/ticket/59168#comment:7.