Iframe: adjust keydown event bubbling#54565
Merged
Conversation
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
|
Flaky tests detected in fa14cd6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6224916108
|
youknowriad
approved these changes
Sep 18, 2023
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
The current implementation prevents any component inside the iframe from listening to events on the document or window. A cleaner solution would be to stop event probation exactly at the element at which we re-dispatch the events: the iframe element.
This you need this in any way?
LGTM regardless
Member
Author
|
Yes, needed in #54543. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The current implementation prevents any component inside the iframe from listening to events on the document or window. A cleaner solution would be to stop event probation exactly at the element at which we re-dispatch the events: the iframe element.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast