Query Loop: Add design enhancements for the "enhanced pagination" setting#54455
Conversation
|
Size Change: +94.4 kB (+6%) 🔍 Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
This is ready for review. @jasmussen, I've added you as a reviewer, as you proposed most of the changes. 🙂 |
|
Nice work, lots of improvements. Without diving too deep into testing, I appreciate the video you shared. In an older video I saw gray placeholders where the images were being loaded, were those removed? I think it can be fine to keep them to indicate "an image will appear here", I think they key is to make them very light colored, and ideally |
Oh, right. That's not part of the enhanced navigation feature. I'm sure @luisherranz added those placeholders manually, just moving the featured images inside a Group block with a custom background color. |
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
|
Flaky tests detected in 4e5760d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6188939516
|
SantosGuillamot
left a comment
There was a problem hiding this comment.
I've been reviewing this and, apart from the comments already left, it seems everything in the issue has been covered and works great 👏 .
This reverts commit fe52845.
What?
This PR addresses most of the tasks listed in #54414 to improve the design of Query Loop's enhanced pagination setting.
Why?
To improve the feature design.
How?
Please take a look at the code changes; they're pretty easy to follow. 🙂
Regarding the loading bar animation, I tried to use an animation timing function that reaches the midpoint in 1-2 seconds approx., and the final point after 30 seconds.
This animation is also disabled when reduced motion is preferred.
Testing Instructions
For the editor changes:
Enhanced pagination will be disabledOKOKFor the loading bar animation:
1.Screenshots or screencast
Screen.Recording.2023-09-14.at.11.17.59.mov
Screen.Recording.2023-09-14.at.11.45.34.mov