Skip to content

Fix overwriting of published post meta when previewing footnote changes#54339

Merged
Mamaduka merged 2 commits intoWordPress:trunkfrom
adamsilverstein:fix/footnotes-live
Sep 27, 2023
Merged

Fix overwriting of published post meta when previewing footnote changes#54339
Mamaduka merged 2 commits intoWordPress:trunkfrom
adamsilverstein:fix/footnotes-live

Conversation

@adamsilverstein
Copy link
Copy Markdown
Member

@adamsilverstein adamsilverstein commented Sep 11, 2023

Fixes bug discovered in #52988

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@adamsilverstein adamsilverstein mentioned this pull request Sep 11, 2023
Merged
@adamsilverstein adamsilverstein added the [Type] Bug An existing feature does not function as intended label Sep 11, 2023
Mamaduka
Mamaduka reviewed Sep 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamsilverstein, just to clarify: this is a different bug discovered while working on #52988 and can be tested/merged separately + recommended to be backported into a minor release.

Are the above statements correct?

P.S. Can you also provide quick testing instructions?

@Mamaduka Mamaduka added the [Block] Footnotes Affects the Footnotes Block label Sep 13, 2023
@jorgefilipecosta
Copy link
Copy Markdown
Member

jorgefilipecosta commented Sep 15, 2023

I think we can merge this PR, update_post_meta is just an update_metadata call, with additional logic to in case of revisions update the original post instead of the revision.

	$the_post = wp_is_post_revision( $post_id );
	if ( $the_post ) {
		$post_id = $the_post;
	}

Here it seems we want to avoid that logic to have the possibility of having revisions for the footnones.

jorgefilipecosta
jorgefilipecosta approved these changes Sep 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me 👍

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Sep 15, 2023

If the e2e fails again, it might require rebasing due to core changes. See #54452.

@adamsilverstein
Copy link
Copy Markdown
Member Author

adamsilverstein commented Sep 26, 2023

Rebased against trunk

@Mamaduka Mamaduka merged commit 2823ea0 into WordPress:trunk Sep 27, 2023
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka left review comments

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

No one assigned

Labels

[Block] Footnotes Affects the Footnotes Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 16.8

Development

Successfully merging this pull request may close these issues.

5 participants

@adamsilverstein @jorgefilipecosta @Mamaduka @bph @mikachan