Patterns: Remove experimental prefixes from patterns package#54338
Merged
glendaviesnz merged 1 commit intotrunkfrom Sep 11, 2023
Merged
Patterns: Remove experimental prefixes from patterns package#54338glendaviesnz merged 1 commit intotrunkfrom
glendaviesnz merged 1 commit intotrunkfrom
Conversation
19 tasks
|
Size Change: -11 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Sep 11, 2023
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
LGTM!
✅ Creation of synced/unsynced patterns continues to work
✅ Manage and detach pattern options still function as before
I also confirmed these weren't exported and no prefixes were missed in the package.
Nice work ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the
__experimentalprefix from the patterns package.Why?
This package currently doesn't have a public API so these are not really.
How?
Removed all occurences of
__experimentalfrom@wordpress/patternspackageTesting Instructions
Create patternoption and make sure this still creates a pattern as expected. Try with both synced and unsynced patternsManage patternsandDetach patternoptions work as expected