Performance: Fix first block locator's page reference#54188
Merged
WunderBart merged 3 commits intotrunkfrom Sep 5, 2023
Merged
Performance: Fix first block locator's page reference#54188WunderBart merged 3 commits intotrunkfrom
WunderBart merged 3 commits intotrunkfrom
Conversation
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
This fixes the intermittent failure where the canvas locator times out after the default 10 seconds.
youknowriad
approved these changes
Sep 5, 2023
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
Thanks for tracking this down. This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Bug: Current page for locating the first block is the one in the background (
page), not the one that is subject to the test (testPage). This might have been the reason for the recently unstable loading metrics.This PR fixes that + makes the Site Editor Loading test consistent with the Post Editor one + increases the timeout value for the canvas locator which fixes its recent flakiness (e.g. this job).