Size Change: +606 B (0%)

Total Size: 1.62 MB

_{compressed-size-action}

@ajlende added the dark check after the media sets custom color.

@ajlende did some refactoring to use retrieving average color functions once. Got rid of an useEffect 🎉 and seems more lean in general. I hope nothing breaks 😁

I am starting over this one.

There are a few things to try and achieve with this:

1. The main objective: to set the overlay color as the average media color for image backgrounds
2. The refactoring objectives:
   2.1 To make sure for the same image background we compute the average media color once
   2.2 To reuse the average background media color in all the computation of the is dark attribute

(2.1) and (2.2) make refactoring annoying because:

• the cover block accrued a lot of features and there are many possible situations
• the average color computation is an async operation which is annoying to memoize
• using a state is not immediately manageable in an effect because of the two ways in which we use the color (hex to store, rgb to compute composite)

Addressed @ajlende latest review and fixed the behavior to respect the manually set color overlay on load. Also tweaked the use featured image behavior.

Updated the OP with a video with current working state.

Following a conversation with @richtabor there is the question of when should the overlay be set from the average color of the background image? All the time when a background image is applied or only if there is no overlay color? Or only when the overlay color is not manually set?

Ideally we would know the difference between an overlay color manually set by a user and one set by the system. And in this PR we do, but only until the page is reloaded.

The best simplification would be to set the overlay from average color of background image only if there is no overlay color and no background image.

Otherwise we'd have to save a new attribute, so that when the user switches the background image we can tell if the color is the one from the previous image average color, or if it's set manually, and on media change only suggest if the color is set by the system.

We need to decide between:

1. leaving it like it is in the PR (on all media changes system will set a new overlay)
2. system setting an overlay only when the block is not setup with overlay or background
3. adding a manualOverlay flag to set so that system sets overlay only when overlay is set previously by syetem

adding a manualOverlay flag to set so that system sets overlay only when overlay is set previously by system.

I think this is the correct path, though it can be in a follow-up to get this in.

I would expect an overlay color suggested as long as I didn’t manually change the color myself. If I set an overlay color, that color should persist on media change.

adding a manualOverlay flag to set so that system sets overlay only when overlay is set previously by syetem.

I wonder if we could use the synchronous FAC API on save when an overlayColor isn't set? Not sure if it would work or if that would cause problems, but it would keep the block API cleaner rather than adding a new attribute.