Skip to content

Update the components changelog to mark the popover slot removal as a breaking change#54022

Merged
youknowriad merged 2 commits intotrunkfrom
update/components-changelog
Aug 31, 2023
Merged

Update the components changelog to mark the popover slot removal as a breaking change#54022
youknowriad merged 2 commits intotrunkfrom
update/components-changelog

Conversation

@youknowriad
Copy link
Copy Markdown
Contributor

Follow-up to #53982 (comment)

@youknowriad youknowriad added [Type] Developer Documentation Documentation for developers [Feature] UI Components Impacts or related to the UI component system labels Aug 29, 2023
@youknowriad youknowriad requested a review from ciampo August 29, 2023 13:28
@youknowriad youknowriad self-assigned this Aug 29, 2023
@youknowriad youknowriad requested a review from ajitbohra as a code owner August 29, 2023 13:28
Copy link
Copy Markdown
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow-up, Riad.

Would it be able to also address some of the comments left by @tyxla in the previous PRs, like fixing this typo ?

Feel free to merge once feedback is addressed :)

Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
@youknowriad
Copy link
Copy Markdown
Contributor Author

Would it be able to also address some of the comments left by @tyxla in the previous PRs, like fixing this #53889 (comment) ?

These have been addressed already.

@youknowriad youknowriad enabled auto-merge (squash) August 30, 2023 13:54
@youknowriad youknowriad disabled auto-merge August 31, 2023 04:30
@youknowriad youknowriad merged commit d67a8d5 into trunk Aug 31, 2023
@youknowriad youknowriad deleted the update/components-changelog branch August 31, 2023 04:31
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] UI Components Impacts or related to the UI component system [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants