Backport themes is_block_theme collection param from core#53846
Merged
ntsekouras merged 2 commits intotrunkfrom Aug 21, 2023
Merged
Backport themes is_block_theme collection param from core#53846ntsekouras merged 2 commits intotrunkfrom
is_block_theme collection param from core#53846ntsekouras merged 2 commits intotrunkfrom
Conversation
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.3/rest-api.php |
t-hamano
approved these changes
Aug 21, 2023
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I have activated the block theme in WordPress 6.2 and tested the following:
- trunk:
wp.data.select('core').getCurrentTheme().is_block_theme>undefined- Commands that should be available when in a block theme are not displayed (Navigation, Styles, Pages, Templates, etc.)
- This PR:
- ✅
wp.data.select('core').getCurrentTheme().is_block_theme>true - ✅ Commands that should be available when in a block theme are displayed as expected.
- ✅
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Currently for the command packages we are using the
is_block_themetheme's collection param to handle some callbacks conditionally. This param though was introduced directly in core here for6.3and since in GB we support one more WP version, we need to add it in GB too, undercompat/6.3files.This PR does that.
Testing Instructions
Have WP
6.2installed.Alternatively of course you can just test the response of a rest client, when requesting themes.